Conversation
This ensures that pressing wizard's Cancel button cancels pending subscriptions.
Contributor
Author
|
@armiol As discussed with Oleg, to speed up rolling out the release, I'm planning to merge this PR as soon as he accepts it. I'll address your comments in a subsequent PR anyway, so please feel free to submit your review even after I merge the PR. |
Oleg-Melnik
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
InputFieldandDropdownSelector.Money.format()extension, which, unlike the existingMoney.formatAmount(), also includes the currency code, which provides a full set of information about the money value that is sufficient to understand its value.Wizardcomponent are cancelled when the "Cancel" button is pressed.ComponentSetupdeclarations (no explicit instance creation is required now). The component's type instantiation is inferred from theComponentSetup's type parameter automatically (using the same mechanism that is used inEntityChooser).coremodule tocodegen-runtimeto prevent inheriting its transitive dependency on protobuf lib(s). According to the Chord's design, Protobuf dependencies can appear "starting" fromchords-proto-values(in those libs that depend on it).